Search: Add docs headings to index#26531
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 192bf87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
shilman
added
feature request
ui: search
ci:normal
|
mark . I really need it |
|
@March-Wind as soon as #30130 (comment) got merged, I'll try it out in this branch |
|
Closing due to inactivity. Please feel free to reopen the PR if you would like to continue working on it. |
|
@valentinpalkovic @shilman I'd like to finish this and prioritized this with my team internally. I start with figuring out at what sate I left the PR but the reason why I haven't finished it last time is that I need help from someone of you to get the last 10-20% done I'll contact you as soon as I'm ready and we'll figure out a slot where we maybe can talk about this. Would that be ok for you? |
|
@shilman @valentinpalkovic I started from scratch because merging next into this PR was not easy. I also wanted to preserve the changes here and started a fresh PR in #33593 I hope that's fine for you as well |
4 participants
Closes N/A
What I did
Work in progress
@storybook/docs-mdxto a version that extracts Markdown headingsChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
For now, run a sandbox and manually inspect its
/index.jsonDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>